Conversation
This new version has breaking API and ABI changes (see #20194).
Use ReadBuffer and WriteBuffer instead of Buffer.
Collaborator
Author
|
Since CI was broken on the last commit, mypy_primer is expected to fail. There are no semantic changes so ignoring mypy_primer breakage seems fine, as long as everything else passes. |
ilevkivskyi
approved these changes
Nov 10, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
I guess you can also remove the union from the librt stubs in this same PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new version has breaking API and ABI changes (see #20194 for context).
This is okay since we haven't made a public release with librt as a dependency yet.
(Note that librt is part of the mypy project but distributed separately.)